From 414c126e8cde3ca5d3f094301b7129c3173c7f72 Mon Sep 17 00:00:00 2001 From: Noah Lemen Date: Wed, 5 Jul 2023 11:10:30 -0400 Subject: [PATCH 1/3] Cleanup unused unstable_* exports --- fixtures/concurrent/time-slicing/src/index.js | 6 +++--- packages/react/index.classic.fb.js | 4 ---- packages/react/index.modern.fb.js | 4 ---- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/fixtures/concurrent/time-slicing/src/index.js b/fixtures/concurrent/time-slicing/src/index.js index 6a880584f0b55..73ea91fddfa97 100644 --- a/fixtures/concurrent/time-slicing/src/index.js +++ b/fixtures/concurrent/time-slicing/src/index.js @@ -1,4 +1,4 @@ -import React, {PureComponent, unstable_startTransition} from 'react'; +import React, {PureComponent, startTransition} from 'react'; import {createRoot} from 'react-dom/client'; import _ from 'lodash'; import Charts from './Charts'; @@ -64,7 +64,7 @@ class App extends PureComponent { } this._ignoreClick = true; - unstable_startTransition(() => { + startTransition(() => { this.setState({showDemo: true}, () => { this._ignoreClick = false; }); @@ -103,7 +103,7 @@ class App extends PureComponent { break; case 'async': // TODO: useTransition hook instead. - unstable_startTransition(() => { + startTransition(() => { this.setState({value}); }); break; diff --git a/packages/react/index.classic.fb.js b/packages/react/index.classic.fb.js index acc415ff563e8..0a8eea654c44d 100644 --- a/packages/react/index.classic.fb.js +++ b/packages/react/index.classic.fb.js @@ -18,7 +18,6 @@ export { StrictMode, Suspense, SuspenseList, - SuspenseList as unstable_SuspenseList, // TODO: Remove once call sights updated to SuspenseList cloneElement, createContext, createElement, @@ -32,7 +31,6 @@ export { memo, cache, startTransition, - startTransition as unstable_startTransition, // TODO: Remove once call sights updated to startTransition unstable_Cache, unstable_TracingMarker, unstable_DebugTracingMode, @@ -48,7 +46,6 @@ export { useContext, useDebugValue, useDeferredValue, - useDeferredValue as unstable_useDeferredValue, // TODO: Remove once call sights updated to useDeferredValue useEffect, experimental_useEffectEvent, useImperativeHandle, @@ -61,7 +58,6 @@ export { useState, useSyncExternalStore, useTransition, - useTransition as unstable_useTransition, // TODO: Remove once call sights updated to useTransition version, } from './src/React'; export {jsx, jsxs, jsxDEV} from './src/jsx/ReactJSX'; diff --git a/packages/react/index.modern.fb.js b/packages/react/index.modern.fb.js index 991bb68ea9126..4b82b6de3de68 100644 --- a/packages/react/index.modern.fb.js +++ b/packages/react/index.modern.fb.js @@ -18,7 +18,6 @@ export { StrictMode, Suspense, SuspenseList, - SuspenseList as unstable_SuspenseList, // TODO: Remove once call sights updated to SuspenseList cloneElement, createContext, createElement, @@ -31,7 +30,6 @@ export { memo, cache, startTransition, - startTransition as unstable_startTransition, // TODO: Remove once call sights updated to startTransition unstable_Cache, unstable_DebugTracingMode, unstable_LegacyHidden, @@ -46,7 +44,6 @@ export { useContext, useDebugValue, useDeferredValue, - useDeferredValue as unstable_useDeferredValue, // TODO: Remove once call sights updated to useDeferredValue useEffect, experimental_useEffectEvent, useImperativeHandle, @@ -59,7 +56,6 @@ export { useState, useSyncExternalStore, useTransition, - useTransition as unstable_useTransition, // TODO: Remove once call sights updated to useTransition version, } from './src/React'; export {jsx, jsxs, jsxDEV} from './src/jsx/ReactJSX'; From a022dc93abeffc606c98da00bb5b5f9b53a5abac Mon Sep 17 00:00:00 2001 From: Noah Lemen Date: Wed, 5 Jul 2023 14:58:57 -0400 Subject: [PATCH 2/3] re-add unstable_SuspenseList export, remove SuspenseList export --- packages/react/index.classic.fb.js | 2 +- packages/react/index.modern.fb.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/index.classic.fb.js b/packages/react/index.classic.fb.js index 0a8eea654c44d..1cc03d9a7804e 100644 --- a/packages/react/index.classic.fb.js +++ b/packages/react/index.classic.fb.js @@ -17,7 +17,7 @@ export { PureComponent, StrictMode, Suspense, - SuspenseList, + SuspenseList as unstable_SuspenseList, cloneElement, createContext, createElement, diff --git a/packages/react/index.modern.fb.js b/packages/react/index.modern.fb.js index 4b82b6de3de68..a8cfc70a63b98 100644 --- a/packages/react/index.modern.fb.js +++ b/packages/react/index.modern.fb.js @@ -17,7 +17,7 @@ export { PureComponent, StrictMode, Suspense, - SuspenseList, + SuspenseList as unstable_SuspenseList, cloneElement, createContext, createElement, From 78b2829740d0b3e4c9f8963ffe6122c84c8e76b6 Mon Sep 17 00:00:00 2001 From: Noah Lemen Date: Wed, 5 Jul 2023 17:11:30 -0400 Subject: [PATCH 3/3] backout changes to SuspenseList exports --- packages/react/index.classic.fb.js | 3 ++- packages/react/index.modern.fb.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/react/index.classic.fb.js b/packages/react/index.classic.fb.js index 1cc03d9a7804e..e5cbd5c95a24e 100644 --- a/packages/react/index.classic.fb.js +++ b/packages/react/index.classic.fb.js @@ -17,7 +17,8 @@ export { PureComponent, StrictMode, Suspense, - SuspenseList as unstable_SuspenseList, + SuspenseList, + SuspenseList as unstable_SuspenseList, // TODO: Remove once call sights updated to SuspenseList cloneElement, createContext, createElement, diff --git a/packages/react/index.modern.fb.js b/packages/react/index.modern.fb.js index a8cfc70a63b98..882240bb53cb2 100644 --- a/packages/react/index.modern.fb.js +++ b/packages/react/index.modern.fb.js @@ -17,7 +17,8 @@ export { PureComponent, StrictMode, Suspense, - SuspenseList as unstable_SuspenseList, + SuspenseList, + SuspenseList as unstable_SuspenseList, // TODO: Remove once call sights updated to SuspenseList cloneElement, createContext, createElement,