From c4cb74792a131f7e45fd0f98d0e1762f3c3266e1 Mon Sep 17 00:00:00 2001 From: Josh Story Date: Wed, 1 May 2024 20:50:41 -0700 Subject: [PATCH] [Tooling] Update critical artifact list When a React PR is opened CI will report large size changes. But for critical packages like react-dom it reports always. In React 19 we moved the build for react-dom the client reconciler from react-dom to react-dom/client This change adds react-dom-client artifacts for stable and oss channels since that is originally what was being tracked. But since react-dom/client always imports react-dom I left the original react-dom packages as critical as well. They are small but it woudl be good to keep an eye on them --- dangerfile.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dangerfile.js b/dangerfile.js index 9c4b7e2183489..c01fa31969dec 100644 --- a/dangerfile.js +++ b/dangerfile.js @@ -44,7 +44,9 @@ const CRITICAL_ARTIFACT_PATHS = new Set([ // We always report changes to these bundles, even if the change is // insignificant or non-existent. 'oss-stable/react-dom/cjs/react-dom.production.js', + 'oss-stable/react-dom/cjs/react-dom-client.production.js', 'oss-experimental/react-dom/cjs/react-dom.production.js', + 'oss-experimental/react-dom/cjs/react-dom-client.production.js', 'facebook-www/ReactDOM-prod.classic.js', 'facebook-www/ReactDOM-prod.modern.js', ]);