Skip to content

Commit

Permalink
Allow LogDevice to build without Submodules (#71)
Browse files Browse the repository at this point in the history
Summary:
As a step in the plan to migrate LogDevice to using fbcode_builder as
the primary build method, allow LogDevice to build without submodules.
In place of the self compiled modules, the CMake scripts will look in
the system (or provided prefix locations) and use precompiled modules
there. Users can then use fbcode_builder to ensure those required
modules are built and available.

* Use new 'folly_test_util' library rather than referencing sources
directly
Pull Request resolved: facebookarchive/LogDevice#71

Reviewed By: AhmedSoliman

Differential Revision: D14578119

Pulled By: calebmarchent

fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
  • Loading branch information
Caleb Marchent authored and facebook-github-bot committed Mar 27, 2019
1 parent d9f24bd commit 8fc2439
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions build/fbcode_builder/specs/rocksdb.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/usr/bin/env python
# Copyright (c) Facebook, Inc. and its affiliates.
from __future__ import absolute_import
from __future__ import division
from __future__ import print_function
from __future__ import unicode_literals


def fbcode_builder_spec(builder):
builder.add_option("rocksdb/_build:cmake_defines", {
"USE_RTTI": "1",
"PORTABLE": "ON",
})
return {
"steps": [
builder.fb_github_cmake_install("rocksdb/_build"),
],
}

0 comments on commit 8fc2439

Please sign in to comment.