1.5.0: meson build fails

[kloczek]

I'm using autogenerated from git tag tar ball https://github.com/facebook/zstd//archive/v1.5.0/zstd-1.5.0.tar.gz

+ /usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload --auto-features=enabled . x86_64-redhat-linux-gnu -D backtrace=false -D bin_tests=true -D build_programs=true -D build_tests=true -D debug_level=0 -D lz4=disabled -D lzma=disabled -D multi_thread=enabled -D static_runtime=false -D zlib=disabled
The Meson build system
Version: 0.58.0
Source dir: /home/tkloczko/rpmbuild/BUILD/zstd-1.5.0/build/meson
Build dir: /home/tkloczko/rpmbuild/BUILD/zstd-1.5.0/build/meson/x86_64-redhat-linux-gnu
Build type: native build
WARNING: Unknown options: "build_programs, build_tests"
The value of new options can be set with:
meson setup <builddir> --reconfigure -Dnew_option=new_value ...
Project name: zstd
Project version: DUMMY
C compiler for the host machine: /usr/bin/gcc (gcc 11.1.1 "gcc (GCC) 11.1.1 20210428 (Red Hat 11.1.1-1)")
C linker for the host machine: /usr/bin/gcc ld.bfd 2.36.1-9
C++ compiler for the host machine: /usr/bin/g++ (gcc 11.1.1 "g++ (GCC) 11.1.1 20210428 (Red Hat 11.1.1-1)")
C++ linker for the host machine: /usr/bin/g++ ld.bfd 2.36.1-9
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program GetZstdLibraryVersion.py found: YES (/usr/bin/python3 /home/tkloczko/rpmbuild/BUILD/zstd-1.5.0/build/meson/GetZstdLibraryVersion.py)
Message: Project version is now: 1.5.0
Library m found: YES
Run-time dependency threads found: YES
Dependency zlib skipped: feature zlib disabled
Dependency liblzma skipped: feature lzma disabled
Dependency liblz4 skipped: feature lz4 disabled
Compiler for C supports arguments -Wextra: YES
Compiler for C supports arguments -Wundef: YES
Compiler for C supports arguments -Wshadow: YES
Compiler for C supports arguments -Wcast-align: YES
Compiler for C supports arguments -Wcast-qual: YES
Compiler for C supports arguments -Wstrict-prototypes: YES
Compiler for C++ supports arguments -Wextra: YES
Compiler for C++ supports arguments -Wundef: YES
Compiler for C++ supports arguments -Wshadow: YES
Compiler for C++ supports arguments -Wcast-align: YES
Compiler for C++ supports arguments -Wcast-qual: YES
meson.build:117: WARNING: Consider using the built-in warning_level option instead of using "-Wextra".
meson.build:118: WARNING: Consider using the built-in warning_level option instead of using "-Wextra".
Message: Enable legacy support back to version 0.5
Message: Enable multi-threading support

lib/meson.build:108:0: ERROR: File ../../../lib/common/zstd_trace.c does not exist.

[tkloczko@barrel zstd-1.5.0]$ find . -name zstd_trace.c
[tkloczko@barrel zstd-1.5.0]$

So looks like there is no that header file in repo.

[terrelln]

Is it possible that you need to clear your cache or something? zstd_trace.c isn't mentioned in the build/meson directory.

grep 'zstd_trace.c' -r build/meson

[kloczek]

Is it possible that you need to clear your cache or something? zstd_trace.c isn't mentioned in the build/meson directory.

Definitelly no .. however I've just manage to build zstd using meson and I'll create PR with two fixes shortly :)

[kloczek]

Gosh I still had patch which have been fising issue #2519 which have been adding that file.

zstd 1.5.0 is OK :)
Sorry my fault :P

Closing