Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zstd should try to draw the progress bar only on TTY #2816

Closed
jimis opened this issue Oct 8, 2021 · 1 comment
Closed

Zstd should try to draw the progress bar only on TTY #2816

jimis opened this issue Oct 8, 2021 · 1 comment
Assignees
Labels

Comments

@jimis
Copy link

jimis commented Oct 8, 2021

I run zstd v1.4.4 as a cron job, and I get a progress bar output even when the stdout and stderr are not tty:

zstd --rm -19 $FILENAME  2>&1 | logger

Zstd tries to draw the progress bar, as a result I see this in the journal:

[386B blob data]

It would be best to imply -q when the stdout/stderr are not a tty. Or at least print \n instead of \r as a separator between the lines.

@terrelln
Copy link
Contributor

terrelln commented Oct 8, 2021

I think implying -q when stderr is not a TTY would make sense.

@jimis jimis changed the title Zstd should only try to draw the progress bar on TTY Zstd should try to draw the progress bar only on TTY Nov 17, 2021
@terrelln terrelln added the release-blocking Must be done by the release label Nov 23, 2021
@binhdvo binhdvo closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants