Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Cannot build Bistro on Debian 9 #28

Closed
arghasen opened this issue Jul 27, 2018 · 4 comments
Closed

Cannot build Bistro on Debian 9 #28

arghasen opened this issue Jul 27, 2018 · 4 comments

Comments

@arghasen
Copy link

When i run run_cmake.sh I get the following error.
admin@instance-bistro-test:/bistro/bistro/bistro/cmake$ ./run-cmake.sh Debug
/bistro/bistro/bistro/cmake/deps /bistro/bistro/bistro/cmake
/bistro/bistro/bistro/cmake
Generating Thrift Files
/bistro /bistro/bistro/bistro
!!! Unrecognized option: /bistro/bistro/bistro/cmake/../../..
Usage: thrift [options] file

@arghasen
Copy link
Author

I was not passing the TEMPLATES_PATH

@snarkmaster
Copy link
Contributor

Thanks for the note, @arghasen ! It looks like the top-of-file docblock needs an update — I will fix it.

By the way, did you find that building in a Docker container via fbcode_builder was not workable for you? It's our main open-source testing path, and it has good build-caching support (both Docker cache & ccache), so it should be nice once you get familiar with the scripts:

https://github.com/facebook/bistro/tree/master/build/fbcode_builder

@arghasen
Copy link
Author

@snarkmaster I had not used docker earlier so it was not a path I tried. I am more comfortable with the standard make /cmake based toolchain.

@snarkmaster
Copy link
Contributor

Got it. For this project, Docker is just a way of getting all the right dependencies in a reliable, automated way. Outside of a controlled container, it's a lot more work to write code that will correctly set up all the dependencies for Bistro. The Docker method still uses automake & cmake to build the various projects.

facebook-github-bot pushed a commit that referenced this issue Mar 14, 2022
Summary:
X-link: facebook/fb303#28

X-link: facebook/fboss#115

X-link: facebook/folly#1736

X-link: facebook/proxygen#403

X-link: facebook/fbthrift#488

This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects.

Reviewed By: mackorone

Differential Revision: D34796774

fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants