Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Remove AddField logic added in #107, leverage logrus logic #127

Closed
marcoguerri opened this issue Jul 28, 2020 · 1 comment
Closed

Remove AddField logic added in #107, leverage logrus logic #127

marcoguerri opened this issue Jul 28, 2020 · 1 comment

Comments

@marcoguerri
Copy link
Contributor

In #107, I added some custom logic to add fields to the logger due to my misunderstanding in reading logrus documentation/source code. Basically, I duplicated a small functionality that logrus already implements. I have gotten in a bit of a rabbit hole with #109 #110 #118 #119 #121 #122 and I'd rather fix this after I land that massive refactor.
@marcoguerri marcoguerri mentioned this issue Jul 28, 2020
Merged
@marcoguerri
Copy link
Contributor Author

Not relevant anymore, after many changes in logger.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcoguerri