Atom freezes with 100% CPU usage when opening preferences

[DanielHoffmann]

Issue and Steps to Reproduce

After doing a clean Atom install (deleting ~/.atom/) and installing Nuclide through apm install nuclide. Open Atom then open Preferences screen, atom freezes with 100% CPU usage.

Expected Behavior

Preferences screen should open normally

Actual Behavior

Atom freezes with 100% CPU usage

Versions

• Atom: 1.10.2
• Nuclide: 0.170.0
• Client OS: OS X El Capitan (10.11.4)

Additional Details

No other packages installed, completely clean install
Seems related to #84

[chrisjones-tripletri]

+1. I installed atom for the first time this morning, then followed the instructions to install nuclide. (Edit to clarify): apm install nuclide worked fine, but installing nuclide in atom (via preferences) crashed. Then, atom crashed each time I restarted it.

[DanielHoffmann]

To me the Nuclide install didn't seem to crash, but the apm install nuclide did exit without any messages (not sure if that is the expected behavior)

[hansonw]

Hmm I managed to reproduce this. It looks like when Atom opens an atom:// URI, it adds an atom: project - then we try to detect the nearest HG repository with findHgRepository, which enters an infinite loop.

@mostafaeweda or @shushz, any idea what the best fix is?

[shushz]

Substitution of nuclideUri.join(workingDirectoryPath, '..') with nuclideUri.dirname(workingDirectoryPath) should do it, I think.

[zertosh]

@shushz This is a bug in nuclideUri.join because path.join('/', '..') === '/.

[mostafaeweda]

@zertosh that's happening with atom:// uris, not local paths.

--> I have a fix coming for this in the works.

[zertosh]

@mostafaeweda I know, nuclideUri.join removes the protocol part and is supposed to run a vanilla path.join on the rest, so the expected behavior should be nuclideUri.join('atom:///', '..') === 'atom:///')

[zertosh]

I looked at nuclideUri and it's assuming that the scheme is always nuclide:// - seems odd.