Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleScopePlugin can't deal with dot directories #2404

Closed
diligiant opened this issue May 29, 2017 · 4 comments · Fixed by #2405
Closed

ModuleScopePlugin can't deal with dot directories #2404

diligiant opened this issue May 29, 2017 · 4 comments · Fixed by #2405
Milestone

Comments

@diligiant
Copy link

Some webpack modules (globalize-webpack-plugin is one) create a dot directory to hold temporary files. This breaks ModuleScopePlugin as it only tests for '.' prefix (requestRelative[0] === '.') instead of matching '../' (requestRelative.startsWith ('../')).

I'll submit a PR if that's ok.

@gaearon
Copy link
Contributor

gaearon commented May 29, 2017

Probably OK. cc @Timer

@Timer
Copy link
Contributor

Timer commented May 29, 2017

Commenting on PR.

@Timer
Copy link
Contributor

Timer commented May 29, 2017

It's really interesting that a webpack plugin touches & creates dot directories in your src/ folder.
Does it clean them up afterwards?

Either way, your proposal seems fine (with an additional case for Windows' \).
Thanks for the report!

@gaearon
Copy link
Contributor

gaearon commented Jun 28, 2017

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants