Blacklist confusing global variables

[sidoshi]

Blacklist confusing global variables set by browser env.
This solves the problem we were trying to solve in #1840 in a better way.
See the list of globals that are blacklisted here

Suggest if there are any additions/deletions to be made in the blacklist.

[sidoshi]

Instead of polluting the main config with the huge list of globals, it would be better if we make a separate eslint env plugin as @satya164 suggested or export it from a different file.

[gaearon]

Something is messed up with the branch.

[sidoshi]

Reverted last commit

[gaearon]

Do you think we could instead import globals and then copy that object and explicitly delete a few things from it? And then use that as our list.

[sidoshi]

Do you mean we should import globals from a separate file without removing any variables and then blacklist variables in the main config?

[gaearon]

I mean something like this:

var globals = require('globals');

var customGlobals = Object.assign({}, globals.browser);
delete customGlobals.name;
delete customGlobals.status;
delete customGlobals.top;
// etc

and then using globals: customGlobals. Can all happen in the same file.

[sidoshi]

That looks good. I will update the code

[gaearon]

I tweaked the list, and changed to use no-restricted-globals (turns out there's already a rule for this). Thanks!

[gaearon]

Please help beta test the new version that includes this change!
#2172

[ljharb]

@doshisid if the list of globals was in a separate package, i'd love a PR to eslint-config-airbnb-base that did the same thing :-)

[sidoshi]

Why list of globals from a separate package? We can use no-restricted-globals as used here. What am I missing?

[ljharb]

@doshisid I'm referring to the long array of strings in this PR, that I'd prefer not to duplicate.

[sidoshi]

There isn't any package that I know of that exports confusing globals. I can publish a package and then submit a PR if that's what you would like.

[ljharb]

That would be awesome! (and we could PR use of that package into create-react-app also, so we'd be sharing the same data source)

[gaearon]

If you don't mind you can create a new package right in this monorepo. So we can quickly update if needed.

[sidoshi]

I created the package and submitted PR. 😄
Though I have no problem in creating a package in this monorepo.
I will submit a PR.

[sidoshi]

If I submit a PR using the package I have already published and the transfer the ownership of that package, Would that work?

[gaearon]

Yep!

[sidoshi]

see #2286