Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brackets to launchEditor.js #2637

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Add Brackets to launchEditor.js #2637

merged 1 commit into from
Jun 27, 2017

Conversation

petetnt
Copy link
Contributor

@petetnt petetnt commented Jun 27, 2017

Hello from the https://github.com/adobe/brackets/ team! 👋

Tested on MacOS, should work on WIN too!

@gaearon
Copy link
Contributor

gaearon commented Jun 27, 2017

Hmm. I think we'll hold off until this is implemented:

https://trello.com/c/ikTpxs58/1424-ability-to-browse-to-a-specific-line-in-a-file-using-command-line

All other editors we autodetect can do this.

@gaearon gaearon modified the milestones: 1.x, 1.0.8 Jun 27, 2017
@petetnt
Copy link
Contributor Author

petetnt commented Jun 27, 2017

Hi @gaearon,

not sure why that ticket is in the Icebox (well I do as the Trello has been been quite mismanaged for a long while as many of the current contributors don't have access...) but Brackets does open the file in the correct line/file automatically (just re-confirmed it on my own computer).

@gaearon
Copy link
Contributor

gaearon commented Jun 27, 2017

Hmm. Correct line didn't work for me on Windows. Maybe Windows version has different CLI arguments?

@petetnt
Copy link
Contributor Author

petetnt commented Jun 27, 2017

Could duplicate the correct line part on Windows too myself, not quite sure why the MacOS version manages to open the correct part anyway without the mapping here anyway: https://github.com/petetnt/create-react-app/blob/dca50a5c3b83e1be4a9c08c63c0a4ac405e1434a/packages/react-dev-utils/launchEditor.js#L55-L95 🤔 🤔

We do handle the linenumber in the format of fullpath:linenumber as seen here https://github.com/adobe/brackets/blob/master/src/document/DocumentCommandHandlers.js#L417-L440 like many other editors, but for some reason it does not work at all when launching from command line on Windows. I'll get to the bottom of this ASAP 👍

@gaearon
Copy link
Contributor

gaearon commented Jun 27, 2017

Thanks for looking! I'll get merged then, but hope this gets fixed.

@gaearon gaearon modified the milestones: 1.0.8, 1.x Jun 27, 2017
@gaearon gaearon merged commit 84299ce into facebook:master Jun 27, 2017
@gaearon gaearon mentioned this pull request Jun 28, 2017
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants