Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github restriction #28

Closed
wants to merge 3 commits into from

Conversation

Jake-Shadle
Copy link
Contributor

This removes the github.com restriction for vendor = false git sources by employing a strategy similar to cargo for uniquely naming arbitrary git source urls. The url is normalized so it is consistently hashed, then combined with the last path component (for most hosted git providers, the name of the repo/project) + - + the hex hash of the normalized url.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2023
@Jake-Shadle
Copy link
Contributor Author

Bump.

@zertosh
Copy link
Contributor

zertosh commented Sep 12, 2023

^ @dtolnay

@facebook-github-bot
Copy link
Contributor

@dtolnay has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

src/buckify.rs Outdated Show resolved Hide resolved
src/buckify.rs Show resolved Hide resolved
src/buckify.rs Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@dtolnay merged this pull request in d294699.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants