From ce5b6384ea81f4146c2d26dcea93567d599cf894 Mon Sep 17 00:00:00 2001
From: mayan <yan.ma@intel.com>
Date: Mon, 17 Jul 2023 10:12:31 +0000
Subject: [PATCH] address comments

---
 velox/docs/functions/spark/comparison.rst |  2 +-
 velox/functions/sparksql/Comparisons.h    | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/velox/docs/functions/spark/comparison.rst b/velox/docs/functions/spark/comparison.rst
index 2a4002907dae..057cd7f117db 100644
--- a/velox/docs/functions/spark/comparison.rst
+++ b/velox/docs/functions/spark/comparison.rst
@@ -6,7 +6,7 @@ Comparison Functions
 
     Returns true if x is within the specified [min, max] range
     inclusive. The types of all arguments must be the same.
-    Supported types are: TINYINT, SMALLINT, INTEGER, BIGINT, DOUBLE, REAL.
+    Supported types are: TINYINT, SMALLINT, INTEGER, BIGINT, DOUBLE, REAL, HUGEINT.
 
 .. spark:function:: equalnullsafe(x, y) -> boolean
 
diff --git a/velox/functions/sparksql/Comparisons.h b/velox/functions/sparksql/Comparisons.h
index 98e2dc92232d..47c16680f0e3 100644
--- a/velox/functions/sparksql/Comparisons.h
+++ b/velox/functions/sparksql/Comparisons.h
@@ -98,27 +98,27 @@ struct GreaterOrEqual : private Less<T> {
 std::shared_ptr<exec::VectorFunction> makeEqualTo(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 std::shared_ptr<exec::VectorFunction> makeLessThan(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 std::shared_ptr<exec::VectorFunction> makeGreaterThan(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 std::shared_ptr<exec::VectorFunction> makeLessThanOrEqual(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 std::shared_ptr<exec::VectorFunction> makeGreaterThanOrEqual(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 inline std::vector<std::shared_ptr<exec::FunctionSignature>>
 comparisonSignatures() {