From c5a52a4bf1bf529fb76980991a0935d5b237d9e0 Mon Sep 17 00:00:00 2001
From: Jeremy Rapin <jrapin@fb.com>
Date: Mon, 15 Feb 2021 11:35:27 +0100
Subject: [PATCH 1/5] Check links only on master

---
 .circleci/config.yml | 23 ++++++++++++++++++++++-
 docs/conf.py         |  1 +
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index cb6f00c76..3dca25bf6 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -131,12 +131,25 @@ jobs:
             . venv/bin/activate
             cd docs/
             make html
-            make linkcheck
 
       - persist_to_workspace:
           root: docs/_build
           paths: html
 
+  docs-links:
+    executor: ubuntu-python37
+
+    steps:
+
+      - ubuntu_restore_all
+
+      - run:
+          name: "Check links"
+          when: always
+          command: |
+            . venv/bin/activate
+            make linkcheck
+
   static:
     executor: ubuntu-python37
 
@@ -310,6 +323,14 @@ workflows:
               only: master
             tags:
               only: /(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(\.post(0|[1-9][0-9]*))?/
+      - docs-links:
+          requires:
+            - install
+              # filters:
+              #   branches:
+              #     only: master
+              #   tags:
+              #     only: /(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(\.post(0|[1-9][0-9]*))?/
       - pypi-deploy:
           requires:
             - install
diff --git a/docs/conf.py b/docs/conf.py
index 215b4bdd7..ae51f0825 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -77,5 +77,6 @@
     "windows.html",
     "https://ieeexplore.ieee.org/*",
     "https://iohprofiler.liacs.nl/",  # server error: bad gateway
+    "https://www.facebook.com/whitehat/",  # server error: 500
     r"https://arxiv.org/abs/*",
 ]  # Transient certificate error :(

From 581bb2d7861f0ed02f3e68455380b48e94ebea92 Mon Sep 17 00:00:00 2001
From: Jeremy Rapin <jrapin@fb.com>
Date: Mon, 15 Feb 2021 11:36:55 +0100
Subject: [PATCH 2/5] nit

---
 .circleci/config.yml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 3dca25bf6..c8c18f30a 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -326,11 +326,11 @@ workflows:
       - docs-links:
           requires:
             - install
-              # filters:
-              #   branches:
-              #     only: master
-              #   tags:
-              #     only: /(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(\.post(0|[1-9][0-9]*))?/
+            # filters:
+            #   branches:
+            #     only: master
+            #   tags:
+            #     only: /(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(\.post(0|[1-9][0-9]*))?/
       - pypi-deploy:
           requires:
             - install

From 4992a0df1b92ccb98c1fdf259179a9a9933b9c3c Mon Sep 17 00:00:00 2001
From: Jeremy Rapin <jrapin@fb.com>
Date: Mon, 15 Feb 2021 11:43:04 +0100
Subject: [PATCH 3/5] mv

---
 .circleci/config.yml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index c8c18f30a..70001c32c 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -148,6 +148,7 @@ jobs:
           when: always
           command: |
             . venv/bin/activate
+            cd docs/
             make linkcheck
 
   static:
@@ -326,11 +327,9 @@ workflows:
       - docs-links:
           requires:
             - install
-            # filters:
-            #   branches:
-            #     only: master
-            #   tags:
-            #     only: /(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(\.post(0|[1-9][0-9]*))?/
+              # filters:
+              #   branches:
+              #     only: master
       - pypi-deploy:
           requires:
             - install

From 2a8d9e9a6ff9bb2cee573eb6757ec89000239597 Mon Sep 17 00:00:00 2001
From: Jeremy Rapin <jrapin@fb.com>
Date: Mon, 15 Feb 2021 11:49:07 +0100
Subject: [PATCH 4/5] doclinkmaster

---
 .circleci/config.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 70001c32c..f26a9a849 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -327,9 +327,9 @@ workflows:
       - docs-links:
           requires:
             - install
-              # filters:
-              #   branches:
-              #     only: master
+          filters:
+            branches:
+              only: master
       - pypi-deploy:
           requires:
             - install

From 7de3f883aa0e69749cd80ee569cfe444d6fdb04a Mon Sep 17 00:00:00 2001
From: Jeremy Rapin <jrapin@fb.com>
Date: Mon, 15 Feb 2021 11:50:38 +0100
Subject: [PATCH 5/5] comment

---
 .circleci/config.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index f26a9a849..7c8f0669e 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -324,7 +324,7 @@ workflows:
               only: master
             tags:
               only: /(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(\.post(0|[1-9][0-9]*))?/
-      - docs-links:
+      - docs-links:  # a bit noisy, so only running on master, and does not stop deployments
           requires:
             - install
           filters: