Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with history v5 #465

Open
miikka opened this issue Jul 21, 2020 · 1 comment
Open

Incompatible with history v5 #465

miikka opened this issue Jul 21, 2020 · 1 comment

Comments

@miikka
Copy link

miikka commented Jul 21, 2020

The documentation suggests using the history package. Recently version 5.0.0 was released and there was a bunch of documented and undocumented breaking changes. At least this one causes problems for me with redux-first-router 2.1.5:

  • history.listen() API changed. The callbacks are now called with an an object of shape Update instead of Location

For me, it causes error TypeError: Cannot read property 'toLowerCase' of undefined from connectRoutes.js.

Workarounds:

  • Keep using history 4.10.1
  • Use rudy-history instead. It seems to be what redux-first-router uses internally.
@Alevale
Copy link

Alevale commented May 1, 2024

Did you also have issues with location.search or location.query ? I am tracking down a bug now where those parameters seem to have disappeared, and I'm not sure if redux-first-router is to blame here, or if it's the history package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants