Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check get_encoding to accept only bytes #24

Open
paul-tharun opened this issue Jan 27, 2023 · 0 comments
Open

Check get_encoding to accept only bytes #24

paul-tharun opened this issue Jan 27, 2023 · 0 comments

Comments

@paul-tharun
Copy link
Collaborator

The get_encoding function accepts both bytes and str( http url) this results in two http calls when the input is a http url.(One in get_encoding , other in read_csv)

TODO:
Check this so the content is fetched before and only bytes are passed to both the get_encoding and read_csv functions.

REF:

if not is_object:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant