Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding icons of each browser and os #719

Closed
loviuz opened this issue Apr 1, 2024 · 2 comments
Closed

Adding icons of each browser and os #719

loviuz opened this issue Apr 1, 2024 · 2 comments

Comments

@loviuz
Copy link

loviuz commented Apr 1, 2024

Is your feature request related to a problem? Please describe.
I would print the browser name and os name with its own icons.

Describe the solution you'd like
I think that this library should contains all main icons for browsers and os.

Describe alternatives you've considered
The alternative is to implement this feature manually.

Additional context
This library could comes with default icons, and its name could be added in the resulting json:

{
  "name": "Firefox",
  "version": "124.0",
  "major": "124",
  "icon": "firefox.png"
}

If this can be an interesting feature, I could be added by me with a pull request, but I do not want to spend time if this feature will not be added in the main repository.

Thanks in advance :-)

@shutter-codes
Copy link

Hey I want to work on this issue.
Can you please assign this to me.

@loviuz
Copy link
Author

loviuz commented Oct 18, 2024

Wonderful! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@faisalman @loviuz @shutter-codes and others