Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow custom circumferences for address.nearbyGPSCoordinate #1357

Closed
xDivisionByZerox opened this issue Sep 8, 2022 · 2 comments
Closed

allow custom circumferences for address.nearbyGPSCoordinate #1357

xDivisionByZerox opened this issue Sep 8, 2022 · 2 comments
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs duplicate Duplicate of another issue/PR m: location Something is referring to the location module p: 1-normal Nothing urgent
Milestone
vFuture

Comments

@xDivisionByZerox
Copy link
Member

This issue represents a todo from our codebase:

faker/src/modules/address/index.ts

Lines 541 to 547 in 5ae93a7

/**
* The distance in km per degree for earth.
*/
// TODO @Shinigami92 2022-04-26: Provide an option property to provide custom circumferences.
const kmPerDegree = 40_000 / 360; // in km/°
const distanceInDegree = distanceInKm / kmPerDegree; // in °

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module labels Sep 8, 2022
@xDivisionByZerox xDivisionByZerox added this to the vFuture milestone Sep 8, 2022
@Shinigami92 Shinigami92 mentioned this issue Dec 25, 2022
Merged
@ST-DDT
Copy link
Member

ST-DDT commented Dec 30, 2022 •
edited
Loading

I dont see a need for this feature and adding support for it increases the complexity using the method. If there is somebody that needs this feature, please tell me.

@ST-DDT ST-DDT added s: waiting for user interest Waiting for more users interested in this feature and removed s: needs decision Needs team/maintainer decision labels Dec 30, 2022
@xDivisionByZerox xDivisionByZerox closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2024
@xDivisionByZerox
Copy link
Member Author

Duplicate of #878

@xDivisionByZerox xDivisionByZerox marked this as a duplicate of #878 Apr 28, 2024
@xDivisionByZerox xDivisionByZerox added duplicate Duplicate of another issue/PR and removed s: waiting for user interest Waiting for more users interested in this feature labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs duplicate Duplicate of another issue/PR m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Todo
Milestone
vFuture
Development

No branches or pull requests
2 participants
@ST-DDT @xDivisionByZerox