Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in typescript and emit usable types #14

Closed
griest024 opened this issue Jan 7, 2022 · 3 comments
Closed

Rewrite in typescript and emit usable types #14

griest024 opened this issue Jan 7, 2022 · 3 comments
Labels
c: feature Request for new feature

Comments

@griest024
Copy link
Contributor

griest024 commented Jan 7, 2022 •
edited by damienwebdev
Loading

No description provided.

@ericjeker
Copy link
Contributor

Not sure if this is a duplicate: #9

@damienwebdev
Copy link
Member

I don't think this is a duplicate. There will be some period of time between @faker-js/faker v6 with Definitely typed and @faker-js/faker some future version where the codebase itself emits the types.

I think we keep this issue to track the future rewrite in typescript.

@damienwebdev damienwebdev changed the title rewrite in typescript Rewrite in typescript and emit usable types Jan 9, 2022
@damienwebdev damienwebdev mentioned this issue Jan 9, 2022
Merged
@Shinigami92 Shinigami92 added the c: feature Request for new feature label Jan 9, 2022
@nick-krantz nick-krantz mentioned this issue Jan 10, 2022
Closed
@damienwebdev damienwebdev linked a pull request Jan 14, 2022 that will close this issue
feat: migrate to typescript #72
Closed
27 tasks
@damienwebdev
Copy link
Member

Closing as this is merged and released as 6.0.0-alpha.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: feature Request for new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrate to typescript faker-js/faker
4 participants
@ericjeker @griest024 @Shinigami92 @damienwebdev