Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fixed datetime types for optional argument #192

Merged
merged 4 commits into from
Jan 18, 2022

Conversation

jared-fraser
Copy link
Contributor

@jared-fraser jared-fraser commented Jan 17, 2022

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: d0cce58

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e524db93201c0008702eb0

😎 Browse the preview: https://deploy-preview-192--vigilant-wescoff-04e480.netlify.app

src/datatype.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added this to the v6.0.0 milestone Jan 17, 2022
@Shinigami92 Shinigami92 requested a review from a team January 17, 2022 08:13
@import-brain import-brain added the s: pending triage Pending Triage label Jan 18, 2022
@prisis prisis merged commit 60b71fd into faker-js:main Jan 18, 2022
Shinigami92 added a commit to MohdImran001/faker that referenced this pull request Jan 18, 2022
@jared-fraser jared-fraser deleted the date-types branch January 21, 2022 00:51
pkuczynski pushed a commit to pkuczynski/faker that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: pending triage Pending Triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants