Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use export default for locales #249

Merged
merged 1 commit into from
Jan 21, 2022
Merged

feat: use export default for locales #249

merged 1 commit into from
Jan 21, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 21, 2022

This change is required to allow exporting types from the the locales/index.ts such as KnownLocales.

Prerequisite for #248

@ST-DDT ST-DDT requested a review from a team as a code owner January 21, 2022 16:16
@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 4d8eeeb

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61eadc501a8833000705144a

😎 Browse the preview: https://deploy-preview-249--vigilant-wescoff-04e480.netlify.app

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 21, 2022
@Shinigami92 Shinigami92 requested a review from a team January 21, 2022 17:13
@griest024
Copy link
Contributor

Should we ignore the failing windows test?

@Shinigami92
Copy link
Member

Should we ignore the failing windows test?

Yes, it has nothing to do with the PR
This is potentially a mocha issue and will be fixed by #235

@Shinigami92 Shinigami92 merged commit 93e8e53 into faker-js:main Jan 21, 2022
@ST-DDT ST-DDT deleted the feature/locales/export-default branch January 21, 2022 22:04
pkuczynski pushed a commit to pkuczynski/faker that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants