Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate signature of faker.date.between(s) #2711

Closed
ST-DDT opened this issue Mar 4, 2024 · 0 comments · Fixed by #2719
Closed

Re-evaluate signature of faker.date.between(s) #2711

ST-DDT opened this issue Mar 4, 2024 · 0 comments · Fixed by #2719
Assignees
@matthewmayer
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: date Something is referring to the date module p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision
Milestone
v9.0

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Mar 4, 2024 •
edited
Loading

Extracted from #2704 to avoid blocking the cleanup progress.

The following suggestions were made so far:

  • Keep from and to as required options.
  • Throw an error if from and to are missing for JS users.
  • Remove hidden fallback to refDate
  • Change toDate to fail, if the given values are passed but aren't valid Date-like values (This affects all date methods).
  • Extend documentation regarding dates after/before a value. (Links to past, future, anytime)
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: date Something is referring to the date module labels Mar 4, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Mar 4, 2024
@ST-DDT ST-DDT mentioned this issue Mar 4, 2024
Merged
@matthewmayer matthewmayer mentioned this issue Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmayer matthewmayer

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: date Something is referring to the date module p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision
Projects
None yet
Milestone
v9.0
Development

Successfully merging a pull request may close this issue.

refactor(date)!: stricter error handling of between matthewmayer/faker
2 participants
@matthewmayer @ST-DDT