Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate fake #79

Merged
merged 4 commits into from
Jan 14, 2022
Merged

feat: migrate fake #79

merged 4 commits into from
Jan 14, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 11, 2022

This is based on top of other TS migrations like #72

This module seems to need some other stuff cause it dynamically requests stuff with e.g. faker[parts[0]][parts[1]]
Usually this will request the name module. (#84)

test with npm run build && npx mocha test/date.unit.js

@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 11, 2022
@Shinigami92 Shinigami92 self-assigned this Jan 11, 2022
@Shinigami92 Shinigami92 changed the base branch from main to migrate-to-typescript January 11, 2022 09:03
@Shinigami92 Shinigami92 mentioned this pull request Jan 11, 2022
src/fake.ts Outdated Show resolved Hide resolved
return str;
}

// console.log('attempting to parse', str);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed, this will not break anything

const token = str.substr(start + 2, end - start - 2);
let method = token.replace('}}', '').replace('{{', '');

// console.log('method', method)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed, this will not break anything

@Shinigami92 Shinigami92 merged commit 90effb7 into migrate-to-typescript Jan 14, 2022
@Shinigami92 Shinigami92 deleted the migrate-fake branch January 14, 2022 15:59
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
Co-authored-by: Honza Machala <[email protected]>
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
Co-authored-by: Honza Machala <[email protected]>
damienwebdev pushed a commit that referenced this pull request Jan 14, 2022
Co-authored-by: Honza Machala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants