Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test that catches errors like #989 #991

Closed
ST-DDT opened this issue May 23, 2022 · 2 comments
Closed

Add integration test that catches errors like #989 #991

ST-DDT opened this issue May 23, 2022 · 2 comments
Assignees
@ST-DDT
Labels
c: chore PR that doesn't affect the runtime behavior c: test p: 2-high Fix main branch
Milestone
v7 - Current Major

Comments

@ST-DDT
Copy link
Member

ST-DDT commented May 23, 2022

Clear and concise description of the problem

Currently, these build errors can only be detected by "external" applications that use our library.

Suggested solution

Add an integration test that uses our library as dependency and execute some of our methods.

Alternative

No response

Additional context
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 2-high Fix main branch c: test labels May 23, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone May 23, 2022
@ST-DDT ST-DDT self-assigned this May 23, 2022
@Shinigami92
Copy link
Member

Kinda done via reworking https://github.com/faker-js/playground
sadly we still need to execute that manually, as we do not have commit-releases (yet?)

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 8, 2022

Shini does this by hand...

@ST-DDT ST-DDT closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: chore PR that doesn't affect the runtime behavior c: test p: 2-high Fix main branch
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

No branches or pull requests
2 participants
@ST-DDT @Shinigami92