Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way of using Response header functions from HttpStatus and HttpError #1752

Open
CaselIT opened this issue Aug 4, 2020 · 2 comments

Comments

@CaselIT
Copy link
Member

CaselIT commented Aug 4, 2020

Response has a series of utility methods for setting complex headers, like Set-Cookie or Link.

It would be nice to have a similar ability also in the HttpStatus and in the HttpError.

While ideally the interface could be duplicated/shared in a common superclass, I think that most of the benefits could be achieved by making the _wsgi_headers and _asgi_headers public and setting the headers of the HttpStatus/HttpError to that value.

def _wsgi_headers(self, media_type=None):

def _asgi_headers(self, media_type=None):

@CaselIT CaselIT changed the title Provide a way of using Resource header functions from HttpStatus and HttpError Provide a way of using Response header functions from HttpStatus and HttpError Aug 29, 2020
@vytas7
Copy link
Member

vytas7 commented Nov 23, 2020

Hi @G-Sheridan !
And thanks for sharing. Sounds like a cool AI/DL project to tinker with!

That being said, I'm afraid this issue falls into the remaining gap towards 1.00 AUC, and towards artificial general intelligence.

Despite a really well written description by @CaselIT, it feels like an open ended issue requiring a principal architectural decision on how we want to organize the core parts of the framework.
Maybe when these decisions are made and documented, it could be a relatively easy issue, but I still think we could find more fitting stuff to onboard newcomers. We actually do happen to have 12 issues labeled as such 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@vytas7 @CaselIT and others