Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generalize validators and support jsonschema-rs #2225

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Apr 4, 2024

Summary of Changes

Extract a common interface for the validator logic, and add support for jsonschema-rs library

Related Issues

Fixes: #2224

@CaselIT
Copy link
Member Author

CaselIT commented Apr 4, 2024

The tests are missing for the new lib

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b27c71) to head (e17ae35).
Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2225   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        65    +2     
  Lines         6931      6987   +56     
  Branches      1258      1266    +8     
=========================================
+ Hits          6931      6987   +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CaselIT CaselIT marked this pull request as ready for review April 11, 2024 19:49
@CaselIT CaselIT requested review from vytas7, nZac and kgriffs April 11, 2024 19:49
@vytas7 vytas7 changed the title Generalize validators and support jsonschema-rs feat: generalize validators and support jsonschema-rs Apr 17, 2024
@vytas7
Copy link
Member

vytas7 commented Sep 20, 2024

I love this improvement, but I would like to coordinate this with an App-wide OpenAPI spec, and App-wide media validators (we would support both ways, just as middleware and hooks coexist).

Unfortunately we won't be able to complete all this before the 4.0 release. Let's circle back on this for 4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize validators to support additional types of validation other than jsonschema
2 participants