Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and handle gRPC status and logs #856

Closed
leodido opened this issue Sep 25, 2019 · 7 comments · Fixed by #1241
Closed

Catch and handle gRPC status and logs #856

leodido opened this issue Sep 25, 2019 · 7 comments · Fixed by #1241

Comments

@leodido
Copy link
Member

leodido commented Sep 25, 2019

What would you like to be added:

Our gRPC server should be able to listen for gRPC runtime statuses and react to them accordingly.

Also the Falco's gRPC server should catch the gRPC logs.

Why is this needed:

The gRPC C++ implementation does not uses exception as per Google C++ coding guide. Thus we do not have exceptions to detect misbehaviours. We need to observer the gRPC internal status and react to it.

For example when input certificates for mutual TLS are wrong (eg., empty files) it segfaults and we are not able to correcly handle it.

Similarly we would like to catch the gRPC C++ implementation logs in order to filter and/or expose them with our logger and our logging format.

Refs #822

@stale
Copy link

stale bot commented Nov 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 24, 2019
@stale stale bot closed this as completed Dec 1, 2019
@fntlnz
Copy link
Contributor

fntlnz commented Dec 1, 2019

Stalebot we need to keep this !!

@fntlnz fntlnz reopened this Dec 1, 2019
@stale stale bot removed the wontfix label Dec 1, 2019
@stale
Copy link

stale bot commented Jan 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 30, 2020
@stale stale bot closed this as completed Feb 6, 2020
@leodido leodido reopened this Feb 28, 2020
@stale stale bot removed the wontfix label Feb 28, 2020
@stale
Copy link

stale bot commented Apr 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 28, 2020
@fntlnz
Copy link
Contributor

fntlnz commented Apr 29, 2020

Oh no please keep!

@stale stale bot removed the wontfix label Apr 29, 2020
@stale
Copy link

stale bot commented Jun 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 28, 2020
@leodido
Copy link
Member Author

leodido commented Jun 29, 2020

In https://github.com/falcosecurity/falco/pull/1241/files we have setup the dispatching of gRPC engine logs to falco_logger.

This should be sufficient for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants