Fastfetch hangs on TerminalFont module after updating to version 1.12.2 #493
Labels
bug
Something isn't working
Comments
We were waiting for the child process but it never returned. I will try reproducing it myself later. |
|
The issue happens when using Windows Terminal. If I start |
|
That was because in WSL we would not try to detect the terminal font of Alacritty or conhost |
|
What's the output of cmd.exe /c 'if exist %LOCALAPPDATA%\\Packages\\Microsoft.WindowsTerminal_8wekyb3d8bbwe\\LocalState\\settings.json ( type %LOCALAPPDATA%\\Packages\\Microsoft.WindowsTerminal_8wekyb3d8bbwe\\LocalState\\settings.json ) else if exist %LOCALAPPDATA%\\Packages\\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\\LocalState\\settings.json ( type %LOCALAPPDATA%\\Packages\\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\\LocalState\\settings.json ) else if exist \"%LOCALAPPDATA%\\Microsoft\\Windows Terminal\\settings.json\" ( type %LOCALAPPDATA%\\Microsoft\\Windows Terminal\\settings.json ) else ( call )' |
|
Does the native Windows binary work for you? |
|
|
Did you run the command in WSL / Windows Terminal? |
The native Windows binary does work for |
|
Good, thanks. |
I ran it from windows terminal using powershell. If I run it with wsl, I get the same output with the following lines prepended to it. |
|
As long as the command exits, it's fine. |
|
I can't reproduce this issue on my laptop. Anyway, I have added a timeout option ( defaults to 1000ms ), so that we kill the child process when the timer expires. I didn't change the related code between 1.11.3 and 1.12.2. Can you verify if 1.11.3 does work for you? |
|
If I download the current 1.12.2 zip from the releases page and run it from the extracted location, fastfetch completes successfully without hanging. The hang issue seems to be only with the brew 1.12.2 package. The brew 1.11.3 package is working. |
|
I did some more troubleshooting. It seems the brew package hangs when there are too many color schemes defined in the Windows Terminal Here is a comparison between running the fastfetch binary from the releases page and running the one provided in the brew package, using default Windows Terminal settings with no extra color schemes defined. If you want to reproduce the hang situation, use the brew package of fastfetch 1.12.2 and add all the color schemes listed here to the Windows Terminal settings.json: https://windowsterminalthemes.dev/ (link to download json of all color schemes at bottom left of page) |
|
Alternatively, here is my full Windows Terminal |
|
Thanks for the troubleshooting. homebrew 1.11.3 is working because it wasn't build with cJSON support I think I know what the problem is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
General description of bug:
Often helpful information:
Output of
fastfetch --version:The content of the configuration file you use (if any)
Output of
env NO_CONFIG=1 fastfetch --load-config all --show-errors --stat --multithreading false --disable-linewrap false --hide-cursor false:Output of
fastfetch --list-features:If fastfatch crashed
Paste the stacktrace here. You may get it with:
If you are able to identify which module crashed, the strace can be helpful too
Program hangs at this point until Ctrl-c is pressed.If you cannot do the instructions above, please upload the core dump file:
If my image logo didn't show / work
--logo-width {WIDTH} --logo-height {HEIGHT}?The text was updated successfully, but these errors were encountered: