Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #47 .
A reflexion is that
RouteDefinition
could rather be because in the context of the compiler I think the compiler would never be called if the schema is undefined and most of the time url, method and httpStatus are not used :And if used with
reply.getSerializationFunction
orreply.compileSerializationSchema
they can be undefined :What do you think ?
Checklist
npm run test
andnpm run benchmark
and the Code of conduct