Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on MySQL 8.x #24

Closed
dublx opened this issue Jun 5, 2019 · 8 comments
Closed

Question on MySQL 8.x #24

dublx opened this issue Jun 5, 2019 · 8 comments

Comments

@dublx
Copy link

dublx commented Jun 5, 2019

Hi,

At the start of the README it's stated:

Disclaimer: MySQL 8.x databases are not compatible ! This plugin is compatible with MySQL 5.5.x, MySQL 5.7.x and MariaDB databases.

I have been using it to connect to a MySQL 8.x installation without any issues.
So what is the reason for the disclaimer?
ps: im using "fastify-mysql": "^0.2.0"

Thanks!

@Eomm
Copy link
Member

Eomm commented Jun 5, 2019

I can't find right now the correct issue I looked at, but the cause of the disclaimer is that this lib:
https://github.com/sidorares/node-mysql2

doesn't support totally that version of MySQL (maybe not some feature):
https://github.com/sidorares/node-mysql2/blob/master/.travis.yml

I can find the right issue but feel free to give it a check

@dublx
Copy link
Author

dublx commented Jun 6, 2019

Thanks!

@mcollina
Copy link
Member

mcollina commented Jun 8, 2019

I’d be happy to support all versions of mysql and mariadb if we can use another client.

@sidorares
Copy link

Mysql8 default auth is supported in [email protected], I'm planning to publish alpha1 as a release today

@sidorares
Copy link

[email protected] is out

@mcollina
Copy link
Member

Thanks

@mcollina
Copy link
Member

@dublx would you like to send a PR?

@Eomm
Copy link
Member

Eomm commented Oct 31, 2019

Relesed in v1.0.0 official support to MySQL8

https://github.com/fastify/fastify-mysql/releases/tag/v1.0.0

Closing

@Eomm Eomm closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants