Use @fastify/cookie for cookie handling

[gurgunday]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

We should move from

session/lib/cookie.js

Lines 5 to 67 in 25b4f6b

	module.exports = class Cookie {
	constructor (cookie, request) {
	const originalMaxAge = cookie.originalMaxAge || cookie.maxAge || null
	this.path = cookie.path || '/'
	this.secure = cookie.secure ?? null
	this.sameSite = cookie.sameSite || null
	this.domain = cookie.domain || null
	this.httpOnly = cookie.httpOnly !== undefined ? cookie.httpOnly : true
	this._expires = null
	if (originalMaxAge) {
	this.maxAge = originalMaxAge
	} else if (cookie.expires) {
	this.expires = new Date(cookie.expires)
	this.originalMaxAge = null
	} else {
	this.originalMaxAge = originalMaxAge
	}
	if (this.secure === 'auto') {
	if (isConnectionSecure(request)) {
	this.secure = true
	} else {
	this.sameSite = 'Lax'
	this.secure = false
	}
	}
	}
	set expires (date) {
	this._expires = date
	}
	get expires () {
	return this._expires
	}
	set maxAge (ms) {
	this.expires = new Date(Date.now() + ms)
	// we force the same originalMaxAge to match old behavior
	this.originalMaxAge = ms
	}
	get maxAge () {
	if (this.expires instanceof Date) {
	return this.expires.valueOf() - Date.now()
	} else {
	return null
	}
	}
	toJSON () {
	return {
	expires: this._expires,
	originalMaxAge: this.originalMaxAge,
	sameSite: this.sameSite,
	secure: this.secure,
	path: this.path,
	httpOnly: this.httpOnly,
	domain: this.domain
	}
	}
	}

to https://github.com/fastify/fastify-cookie/blob/master/cookie.js

It requires moderate refactoring

Motivation

No response

Example

No response

[karankraina]

Taking this up

[karankraina]

Hi @gurgunday The link to cookie.js file in the issue description is broken. Can you please guide what exactly we need to do here.

[jsumners]

From the issue description: this module is using an embedded ("vendored") script to parse and generate cookies. Instead, it should use the @fastify/cookie module.

[gurgunday]

@jsumners is right, that was my intention but I took a look again and it seems mostly like a class/interface to manipulate cookie options before passing it to fastify-cookie

So it seems fine to me now

Closing