From fe376d7888b5cd0f7b7ac0c40a51f076310e7aa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=BCrg=C3=BCn=20Day=C4=B1o=C4=9Flu?= Date: Mon, 29 Apr 2024 18:16:35 +0200 Subject: [PATCH] chore: exclude Node 14 and 16 on macos (#127) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * chore: exclude Node 14 and 16 on macos Related to https://github.com/fastify/.github/issues/37. This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations Signed-off-by: Simone Busoli * remove os matrix from package --------- Signed-off-by: Simone Busoli Co-authored-by: Gürgün Dayıoğlu --- .github/workflows/plugins-ci-package-manager.yml | 7 ++----- .github/workflows/plugins-ci.yml | 4 ++++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/plugins-ci-package-manager.yml b/.github/workflows/plugins-ci-package-manager.yml index c54680b..58b963e 100644 --- a/.github/workflows/plugins-ci-package-manager.yml +++ b/.github/workflows/plugins-ci-package-manager.yml @@ -6,20 +6,18 @@ on: jobs: pnpm: name: pnpm - runs-on: ${{ matrix.os }} + runs-on: ubuntu-latest permissions: contents: read strategy: matrix: node-version: [16, 18, 20, 21] - os: [ubuntu-latest] pnpm-version: [8] # pnpm@8 does not support Node.js 14 so include it separately include: - node-version: 14 os: ubuntu-latest pnpm-version: 7 - steps: - name: Check out repo uses: actions/checkout@v4 @@ -44,13 +42,12 @@ jobs: yarn: name: Yarn - runs-on: ${{ matrix.os }} + runs-on: ubuntu-latest permissions: contents: read strategy: matrix: node-version: [14, 16, 18, 20] - os: [ubuntu-latest] steps: - name: Check out repo uses: actions/checkout@v4 diff --git a/.github/workflows/plugins-ci.yml b/.github/workflows/plugins-ci.yml index 0af91b6..b9a1829 100644 --- a/.github/workflows/plugins-ci.yml +++ b/.github/workflows/plugins-ci.yml @@ -108,6 +108,10 @@ jobs: exclude: - os: windows-latest node-version: 14 + - os: macos-latest + node-version: 14 + - os: macos-latest + node-version: 16 steps: - name: Check out repo uses: actions/checkout@v4