Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate secret and/or config stores from environment variables #359

Open
joeshaw opened this issue Apr 12, 2024 · 3 comments
Open

Populate secret and/or config stores from environment variables #359

joeshaw opened this issue Apr 12, 2024 · 3 comments
Labels
feature-ux Concerning ergonomics and ease-of-use good first issue Good for newcomers

Comments

@joeshaw
Copy link
Member

joeshaw commented Apr 12, 2024

You can populate config or secret stores either inline in the fastly.toml file or by reading a file from disk. It would be nice if you could also populate them with environment variables from the host environment.

My current use case for this is passing in an API credential when running Viceroy in a test runner mode. I don't want to check this credential into git, and I would rather not have to bother with an external, local-only file.

@joeshaw joeshaw added feature-ux Concerning ergonomics and ease-of-use good first issue Good for newcomers labels Apr 12, 2024
@cee-dub
Copy link
Contributor

cee-dub commented Apr 12, 2024

This is sort of the opposite direction of what I'd like to do, which is to populate environment variables within the process space from (probably) a config store.

@joeshaw
Copy link
Member Author

joeshaw commented Apr 12, 2024

Yes, but I don't view the two as mutually exclusive. And depending on how we namespace things, it's maybe possible that an environment variable FOO_BAR=baz in the host environment is also FOO_BAR=baz in the guest environment.

@cee-dub
Copy link
Contributor

cee-dub commented Apr 13, 2024

Unintentional if it sounded like I was saying these were in conflict or this wouldn't also be very useful. It's a good fit for a tool like Viceroy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-ux Concerning ergonomics and ease-of-use good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants