Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set dims to longitude and latitude in EQLHarmonic if projection is passed #233

Closed
santisoler opened this issue Apr 23, 2021 · 3 comments
Closed

Set dims to longitude and latitude in EQLHarmonic if projection is passed #233

santisoler opened this issue Apr 23, 2021 · 3 comments
Labels
enhancement Idea or request for a new feature

Comments

@santisoler
Copy link
Member

santisoler commented Apr 23, 2021 •
edited
Loading

Description of the desired feature

When using EQLHarmonic to predict a given field on any set of points through the grid and profile methods we can optionally pass a projection in order to get the resulting object in geographic coordinates. Would be nice if these two methods change the dims to ("latitude", "longitude") if projection is not None and the dims parameter hasn't been passed.

Are you willing to help implement and maintain this feature? Yes
@santisoler santisoler added good first issue Good for newcomers (doesn’t require deep knowledge of the project) enhancement Idea or request for a new feature help wanted labels Apr 23, 2021
@santisoler santisoler changed the title Set dims to longitude and latitude in EQLs if projection is passed Set dims to longitude and latitude in EQLHarmonic if projection is passed Apr 23, 2021
@santisoler santisoler removed good first issue Good for newcomers (doesn’t require deep knowledge of the project) help wanted labels Apr 23, 2021
@santisoler
Copy link
Member Author

@leouieda should we change this in Verde directly?

@leouieda
Copy link
Member

@santisoler that seems like a decent default. Definitely should be changed in Verde directly.

@santisoler santisoler mentioned this issue Jul 19, 2021
Open
6 tasks
@santisoler
Copy link
Member Author

Closing this issue since this should be solved upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Idea or request for a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leouieda @santisoler