Rewrite check for point inside tesseroid with Numba #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the functions that checks if a computation point falls inside a tesseroid using Numba instad of Numpy. This greatly reduce the memory need of the Numpy functions, that required to build large matrices even for medium-size problems.
Also, extend the tests for those cases of multiple observation points and tesseroids.
leouieda
reviewed
Jul 1, 2023
| conflicting = [] | ||
| for i in range(longitude.size): | ||
| for j in range(tesseroids.shape[0]): | ||
| if _check_point_inside_tesseroid( |
There was a problem hiding this comment.
@santisoler is it worth having a function here? The function itself is a single if and is called inside another if.
There was a problem hiding this comment.
Not at all. I coded this fairly quickly and I was prototyping a little bit with parallelization of the checks. I ultimately decided to keep them in serial. I've already merged the two functions into a single one.
Include the if statement in the function that runs the for loop over observation points and tesseroids.
…to fix-tesseroids-bug
|
@leouieda I think this is ready to be merge. If you would like to give it a second look, feel free to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the functions that checks if a computation point falls inside a tesseroid using Numba instad of Numpy. This greatly reduce the memory need of the Numpy functions, that required to build large matrices even for medium-size problems.
Relevant issues/PRs:
Fixes #417