Extend support to Python 3.12 #484
Conversation
Bump Python version in CI to check if all tests pass and documentation builds properly in the latest version of Python.
|
Test fails because there's an issue with Verde and |
|
Haha, apparently after closing fatiando/verde#448, this PR was automatically closed. I'm reopening it since we do want to apply these changes despite the ones introduced in Verde. Reminder to be careful about using the words "resolve", "fix", "closes" in comments 😁 |
|
Oops |
| @@ -35,7 +36,7 @@ dependencies = [ | |||
| "scikit-learn >= 0.24", | |||
| "numba >= 0.52", | |||
| "xarray >= 0.16", | |||
| "verde >= 1.7", | |||
| "verde >= 1.8.1", | |||
There was a problem hiding this comment.
Are you sure this is required here? It's an issue with Verde only in Python 3.12 and Verde 1.7 should still work with previous Pythons.
There was a problem hiding this comment.
I'm not sure what to do here. If you're running Python 3.12 you need Verde >= v1.8.1.
There was a problem hiding this comment.
Yeah, you're right. I guess we should just bump the requirement here. It doesn't really have a huge impact and Verde 1.8 didn't break anything.
Use the same minimum versions as Verde
We can fix the issues with Numpy 2.0.0 in a separate PR.
Convert Numpy scalars to Python numbers so the outputs of examples that are being compared when running doctests support Numpy>=2.0.
santisoler
force-pushed
the
extend-py-3.12
branch
from
cf5ecb6
to
2083afe
Compare
Bump minimum required Python version in CI. Bump Python version in
environment.yml. Bump minimum version for some dependencies inpyproject.toml, requiring at minimum the ones that work on Python 3.12. Add classifier inpyproject.tomlfor Python 3.12.