Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reduce_to_pole work for arbitrary dimension names #509

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Make reduce_to_pole work for arbitrary dimension names #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9762d0b
fix bug #439 with reduction_to_pole filter error when coordinate name…
zaarcvon Jun 13, 2024
8978bbf
add test function for reduction_to_pole transformation
zaarcvon Jun 14, 2024
3ebe5ae
Make format
YagoMCastro Aug 12, 2024
6ed65a9
Merge branch 'main' into fix-reduction_to_pole-coord-name-bug
santisoler Aug 12, 2024
44c6db4
Make format using Black 24.4.2
YagoMCastro Aug 12, 2024
dd91935
Merge branch 'main' into fix-reduction_to_pole-coord-name-bug
santisoler Aug 12, 2024
2aa50c2
Merge branch 'main' into fix-reduction_to_pole-coord-name-bug
santisoler Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion harmonica/filters/_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ def reduction_to_pole_kernel(
magnetization_declination,
)
# Set 0 wavenumber to 0
da_filter.loc[dict(freq_northing=0, freq_easting=0)] = 0
da_filter.loc[{dims[0]: 0, dims[1]: 0}] = 0
return da_filter


Expand Down
10 changes: 10 additions & 0 deletions harmonica/tests/test_transformations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,16 @@ def test_upward_continuation(sample_g_z, sample_g_z_upward):
xrt.assert_allclose(continuation, g_z_upward, atol=1e-8)


def test_reduction_to_pole(sample_potential):
"""
Test reduction_to_pole function with non-typical dim names
"""
renamed_dims_grid = sample_potential.rename(
{"easting": "name_one", "northing": "name_two"}
)
reduction_to_pole(renamed_dims_grid, 60, 45)


class TestTotalGradientAmplitude:
"""
Test total_gradient_amplitude function
Expand Down