Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continued support for importing vanilla CSS files #49

Closed
FND opened this issue Apr 29, 2018 · 4 comments
Closed

continued support for importing vanilla CSS files #49

FND opened this issue Apr 29, 2018 · 4 comments

Comments

@FND
Copy link
Contributor

FND commented Apr 29, 2018

Importing .css files has been deprecated: sass/libsass#2613 (rationale in sass/libsass#2611)

We want to continue to support this (e.g. to bundle non-Sass libraries), so we should either create a custom importer or specify .css as an additional extension (preferably the former to bypass Sass processing).

@xzyfer
Copy link

xzyfer commented Apr 30, 2018

Not using additional extensions does not bypass sass processing. All extensions are parsed as Sass files.

@FND
Copy link
Contributor Author

FND commented Apr 30, 2018

Thanks for chiming in here, @xzyfer! Unfortunately, we're not quite sure yet what this actually means in practice: sass/libsass#2611 states that code importing vanilla CSS files "will not be portable" - but isn't CSS a subset of Sass anyway, so what might actually go wrong as a consequence of treating *.css as Sass modules?

We wouldn't want for faucet to depart from or even work against Sass norms, but we're uncertain what the right way is to proceed here.

@mkhl
Copy link

mkhl commented Jun 8, 2018

For tracking purposes: sass/node-sass#2362

@moonglum
Copy link
Member

This is done with Release 1.0.0-rc.9 by switching from node-sass to sass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants