Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Pinning with Faye Websockets #75

Open
ashenwgt opened this issue Jul 11, 2019 · 2 comments
Open

SSL Pinning with Faye Websockets #75

ashenwgt opened this issue Jul 11, 2019 · 2 comments

Comments

@ashenwgt
Copy link

I am aware that many websocket libraries in the client-side use faye-websockets to make use of its standards-compliant websocket behaviour. However, those libraries cannot be used to implement SSL pinning (e.g. sockjs-client). Is there any chance that users can implement SSL pinning with faye-websockets? If there is no such official approach, could you please provide any advise for developing such functionality for websockets?

@jcoglan
Copy link
Collaborator

jcoglan commented May 14, 2020

@ashenwgt Could you explain to me what SSL pinning is and what kind of functionality you're looking for? It would help me to understand what changes might be necessary for us to support this.

@jcoglan
Copy link
Collaborator

jcoglan commented May 14, 2020

I would add that the Client class does accept a tls option, which is passed directly through to the Node tls.connect() function. See here: https://github.com/faye/faye-websocket-node#initialization-options

So, any options Node's tls module supports are also supported by our Client class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants