Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why is it necessary for scrollNotificationFunc to always return true? #175

Open
lisamartin00 opened this issue May 28, 2021 · 0 comments
Labels
question Further information is requested wontfix This will not be worked on

Comments

@lisamartin00
Copy link

Based on our debugging this morning, our team believes we cannot wrap DashChat with RefreshIndicator because scrollNotificationFunc returns true for the NotificationListener's onNotification. This essentially suppresses scroll events and prevents them from bubbling up.

We are currently on a fork and can flip this to false for our own needs, but I'm curious:

  1. Why does this return true in the first place? It looks like it's related to adding the ScrollToBottom widget functionality: 91f4eeb
  2. Are there implications to flipping this to false that our team has not anticipated?

Thanks so much for your time and help!

@lisamartin00 lisamartin00 added the question Further information is requested label May 28, 2021
@SebastienBtr SebastienBtr added the wontfix This will not be worked on label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants