Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 support to FileSource #1548

Closed
qooba opened this issue May 7, 2021 · 1 comment · Fixed by #1789
Closed

Add S3 support to FileSource #1548

qooba opened this issue May 7, 2021 · 1 comment · Fixed by #1789

Comments

@qooba
Copy link
Contributor

qooba commented May 7, 2021

Is your feature request related to a problem? Please describe.
It should be possible to use s3 file path directly in FileSource
eg.

driver_hourly_stats = FileSource(
    path="s3://driver/driver_stats.parquet",
    event_timestamp_column="datetime",
    created_timestamp_column="created",
)

additionally it should be possible to use custom S3 endpoints.

Describe the solution you'd like
I have added S3 support which is internally handled by pyarrow and pandas.
It is also possible to use custom S3 endpoints using FEAST_S3_ENDPOINT_URL environment variable

@woop
Copy link
Member

woop commented May 12, 2021

Thanks for this @qooba. Also, thank you for being so patient with our delayed reviews. We're hoping to speed things up going forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants