feast apply does not remove deleted feature views from Redis

[adchia]

Expected Behavior

The Redis online store removes materialized feature views if they are no longer present in the repo

Current Behavior

Nothing happens on feast apply. This is particularly bad because Redis is in-memory, so deleted feature views that aren't accessed incur a continued hit on resources (as opposed to other stores where this is written to disk)

[loftiskg]

@adchia Is this currently being worked on? I think this would be pretty easy to add now that #1965 has been merged. Happy to give it a shot if not.

[adchia]

@loftiskg

don't think so. give it a whirl and thanks for following up!

[loftiskg]

actually, taking a closer look, looks like #1965 actually added this.

feast/sdk/python/feast/infra/online_stores/redis.py

Lines 82 to 95 in c59ec58

	def update(
	self,
	config: RepoConfig,
	tables_to_delete: Sequence[Union[FeatureTable, FeatureView]],
	tables_to_keep: Sequence[Union[FeatureTable, FeatureView]],
	entities_to_delete: Sequence[Entity],
	entities_to_keep: Sequence[Entity],
	partial: bool,
	):
	"""
	We delete the keys in redis for tables/views being removed.
	"""
	for table in tables_to_delete:
	self.delete_table_values(config, table)

I think this issue is probably good to close.