Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip install feast pulls in latest external dependencies that drop python 3.7 support #2314

Closed
shihgianlee opened this issue Feb 16, 2022 · 3 comments
Assignees
Labels

Comments

@shihgianlee
Copy link

Expected Behavior

pip install feast[gcp]==0.17.0 should install feast successfully

Current Behavior

pip install feast[gcp]==0.17.0 failed to install when the external libraries it depends on don't support python 3.7.

Steps to reproduce

Reproduce using Conda:

> conda create --name feast-test python=3.7
> pip install feast[gcp]==0.17.0

I used Conda 4.8.5 on my local MacOS 12.1

Reproduce using Dockerfile:

FROM debian:10

RUN apt-get update -qq && apt-get upgrade -y
RUN apt-get install python3 python3-venv python3-pip git curl jq libpq-dev -y

RUN pip3 install feast[gcp]==0.17.0
@adchia
Copy link
Collaborator

adchia commented Apr 21, 2022

is this still an issue?

Not sure what the exact issue was here, but I can repro a pyarrow issue that is only specific to if you don't have wheel installed.

@shihgianlee
Copy link
Author

The issue was feast[gcp]==0.17.0 doesn't support python 3.7 due to unpinned external dependencies. This is not an issue for me anymore after I pinned the numpy version (if I remember correctly) that supports python 3.7. The Feast test passed with python 3.7 support. @woop suggested me to open an issue.

@achals
Copy link
Member

achals commented Jul 12, 2022

Following https://numpy.org/devdocs/release/1.22.0-notes.html, we're planning on dropping support for python 3.7 in Feast as well. #2934

@achals achals closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants