Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature repo setup for Java integration tests is broken #2522

Closed
felixwang9817 opened this issue Apr 11, 2022 · 1 comment
Closed

Feature repo setup for Java integration tests is broken #2522

felixwang9817 opened this issue Apr 11, 2022 · 1 comment

Comments

@felixwang9817
Copy link
Collaborator

Expected Behavior

The feature repo that is set up for Java integration tests with docker compose (see feast/java/serving/src/test/resources/docker-compose/feast10) should rely on the most recent Feast code (e.g. for a PR, it should pull from the latest commit on the PR).

Current Behavior

Instead, the feature repo pulls from main: RUN git clone https://github.com/feast-dev/feast.git /root/feast. This means that breaking changes might not be caught. As an example, #2488 made a breaking change, but the Java integration tests still passed on the PR; once the PR was merged in, the tests began to fail.

Steps to reproduce

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

Pull code from the latest commit on the PR instead of main.

@pyalex
Copy link
Collaborator

pyalex commented May 6, 2022

Fixed by #2645

@pyalex pyalex closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants