Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRegistry _apply_object doesn't take into account match with project_id when updating row #4027

Closed
Nmroth42 opened this issue Mar 21, 2024 · 2 comments · Fixed by #4042
Closed

Comments

@Nmroth42
Copy link
Contributor

Nmroth42 commented Mar 21, 2024

SqlRegistry _apply_object doesn't take into account match with project_id when updating row.
https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/registry/sql.py#L736

Wrong (as is):
.where(getattr(table.c, id_field_name) == name)

Correct:
.where(getattr(table.c, id_field_name) == name, table.c.project_id == project)

@Nmroth42 Nmroth42 changed the title SqlRegistry _apply_object doesn't take into account match with project_id on update SqlRegistry _apply_object doesn't take into account match with project_id when updating row Mar 21, 2024
@tokoko
Copy link
Collaborator

tokoko commented Mar 25, 2024

@Nmroth42 thanks, would you like to open a PR for this?

@Nmroth42
Copy link
Contributor Author

#4042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants