Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feast create empty online table when FeatureView attribute online=False #4616

Open
SuperBo opened this issue Oct 11, 2024 · 1 comment
Open

Comments

@SuperBo
Copy link

SuperBo commented Oct 11, 2024

Expected Behavior

Feast shouldn't create any DynamoDB table when I defined FeatureView with online=False.

Current Behavior

Feast creates empty DynamoDB table when I defined FeatureView with online=False.

Steps to reproduce

Define a feature store like this

project: example_feature_sotre

provider: aws

offline_store:
  type: spark
  spark_conf: {}

online_store:
  type: dynamodb
  region: us-east-1

entity_key_serialization_version: 2

Feature view def

feature_view = FeatureView(
    name="abc_details_monthly",
    entities=[user_id],
    online=False,
    source=SparkSource(
      table="shcema.abc_details_monthly",
      name="abc_details_monthly",
      timestamp_field="event_date",,
      ttl=datetime.timedelta(days=27),
    # Schema definition
    schema=[
        Field(
            name="feature_1_1d",
            dtype=types.Int32,
            description=""
        )
    ]
)

Specifications

  • Version: 0.40.1
  • Platform: Linux
  • Subsystem:

Possible Solution

Should distinguish list tables to keep of online store and offline store in this file.

@franciscojavierarceo
Copy link
Member

Yeah, agree wasted space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants