Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend auth integration tests #860

Closed
woop opened this issue Jul 4, 2020 · 2 comments
Closed

Extend auth integration tests #860

woop opened this issue Jul 4, 2020 · 2 comments
Labels
kind/housekeeping wontfix This will not be worked on

Comments

@woop
Copy link
Member

woop commented Jul 4, 2020

We currently have testing of authentication and authorization through unit tests on Feast Core and as part of the Python SDK e2e tests.

This issue is to track the extension of Feast Core tests to include proper client/server integration tests with a real database (postgres) as opposed to mocks.

@woop
Copy link
Member Author

woop commented Jul 15, 2020

Lets use this issue to list out the specific test cases that we have to have in order to ensure Feast auth is minimally covered.

We should test the following as integration tests

  1. Feast Core and Feast Serving with authentication enabled but no authorization. Feast Serving should send authorized requests to Feast Core. Clients to both should be forced to provide auth details.
  2. Feast Core and Feast Serving with authentication and authorization enabled. We should ensure that users cannot modify feature sets in projects for which they are not members. All other functionality should remain unaffected.
  3. The functionality at SDK level should be tested, including setting Google credentials or Oauth2 creds. Both towards Feast Core and Feast Serving.
  4. We should have a basic load test on Feast Serving to show that there is no negative impact based on the changes we are incorporating here.

@stale
Copy link

stale bot commented Sep 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 13, 2020
@stale stale bot closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/housekeeping wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant