Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Contribution: tables & views #929

Open
zenoamaro opened this issue Jun 13, 2020 · 7 comments · May be fixed by #932
Open

Icon Contribution: tables & views #929

zenoamaro opened this issue Jun 13, 2020 · 7 comments · May be fixed by #932

Comments

@zenoamaro
Copy link

zenoamaro commented Jun 13, 2020

Tables & Views

This is a set of related icons to represent tables, grids, matrices for rich-text editing, data manipulation, database administration, development tools.

Table

  • Icon name: table
  • Use case: tables in rich text editors; database tables
  • Screenshots of similar icons: (see below)

Observable

  • Icon name: observable or observe or view or spy or eye-box
  • Use case: database views and real-time computed objects; sensors; view and focus modes; observing modes
  • Screenshots of similar icons: (see below)

Matrix

  • Icon name: matrix
  • Use case: calculation grids and matrices (but not layouts)
  • Screenshots of similar icons: (see below)

Data

  • Icon name: data or dataset
  • Use case: labeled collections of data
  • Screenshots of similar icons: (see below)

Proposal

Icons are based on columns (included for reference and visual continuity). SVG and Figma file are attached below.

Original size

Embiggened

Icons - Tables and Views.zip

Encounters in the wild

Screenshot 2020-06-13 at 02 46 45

Screenshot 2020-06-13 at 02 46 58

@locness3
Copy link

That's very nice, you should follow #171 to submit them (although they won't get soon merged)

@johnletey
Copy link

@zenoamaro Love those 😍🔥

I am starting to build (and deploy) a fork of this library at jletey/feather. If you want, you can also submit a PR there so you can use your icons in the wild sooner 😄

@johnletey
Copy link

johnletey commented Jun 13, 2020

Screenshot 2020-06-13 at 09 48 43

@zenoamaro What do you think of the middle icon? I personally think it's better than yours (the left icon) and also not too weird like the right icon.

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M5 12C5 12 7.54545 7 12 7C16.4545 7 19 12 19 12C19 12 16.4545 17 12 17C7.54545 17 5 12 5 12Z" />
  <path d="M12 13C12.5523 13 13 12.5523 13 12C13 11.4477 12.5523 11 12 11C11.4477 11 11 11.4477 11 12C11 12.5523 11.4477 13 12 13Z" />
  <path d="M21 8V5C21 4.46957 20.7893 3.96086 20.4142 3.58579C20.0391 3.21071 19.5304 3 19 3H5C4.46957 3 3.96086 3.21071 3.58579 3.58579C3.21071 3.96086 3 4.46957 3 5V8M21 16V19C21 19.5304 20.7893 20.0391 20.4142 20.4142C20.0391 20.7893 19.5304 21 19 21H5C4.46957 21 3.96086 20.7893 3.58579 20.4142C3.21071 20.0391 3 19.5304 3 19V16" />
</svg>

@zenoamaro
Copy link
Author

zenoamaro commented Jun 13, 2020

@jletey, that's perfect! Cool, thanks! I'll send a PR soon.

@locness3, thanks! I am assuming guidelines are ok, and the only thing left is a PR right? I'll send one soon. Do you have an opinion on the icon names, or shall I pick?

@johnletey
Copy link

I am assuming guidelines are ok, and the only thing left is a PR right?

Correct!

Do you have an opinion on the icon names, or shall I pick?

The names you have right now are fine 👍

@locness3
Copy link

You may also want to submit to @featherity 😂

@zenoamaro zenoamaro linked a pull request Jun 15, 2020 that will close this issue
@mittalyashu
Copy link
Contributor

Screenshot 2020-06-25 at 4 43 05 PM

I am not sure where we could use the last icon but doesn't first icon looks similar to calculator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants