New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transport-commons): New built-in high performance radix router #2177

Merged

daffl merged 3 commits into dove from routing

Jan 5, 2021

Member

daffl commented Jan 3, 2021

This pull request replaces the radix-router package with our own Radix Tree for fast route lookups. Reasons:

Fixes inconsistencies in lookup between Express (closes Nested route issue with radix-router #2006)
Built-in and TypeScript version makes it easier to use for other frameworks (e.g. Koa) and platforms (e.g. Deno)
While other frameworks like Fastify use radix trees for lookups their routers only work with HTTP requests and response. Since it is transport independent, Feathers needs a more general purpose routing system.

daffl added 3 commits

January 2, 2021 17:09


          feat(transport-commons): New built-in high performance radix router

9d41699


          Small refactoring

6b9f10a


          Improve typings

9a4d8a0

daffl merged commit 6d18065 into dove

daffl deleted the routing branch

January 5, 2021 04:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet