Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update repository urls #2380

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Conversation

lukashass
Copy link
Contributor

@lukashass
Copy link
Contributor Author

The changelogs of adapter-commons, adapter-tests and memory also include links to https://github.com/feathersjs/databases. I'm happy to change those as well, if you like.

@daffl
Copy link
Member

daffl commented Jun 7, 2021

Thank you! Makes sense to probably change those as well since the repository has been removed completely.

@lukashass
Copy link
Contributor Author

I changed the urls in the changelogs, but left some occurrences of https://github.com/feathersjs/databases as they were. They would otherwise point to an existing, but wrong issue. For example these urls.

@daffl
Copy link
Member

daffl commented Jun 8, 2021

Great, thank you! I guess it continued to generate wrong Changelog links because of the wrong reference package.json.

@daffl daffl merged commit 3f4db68 into feathersjs:dove Jun 8, 2021
@lukashass lukashass deleted the fix-repository-urls branch November 30, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants